fix: add java17 as compatible runtime in collector makefile #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkan-ozal
reviewed
Jan 16, 2025
tylerbenson
approved these changes
Jan 16, 2025
Member
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
In addition to @serkan-ozal's request, I suggest adding a comment to each language's layer publish workflow that points here, encouraging any updates to be applied in both places.
arun-annamalai
force-pushed
the
java17makefile
branch
from
a68db58 to
ca30dc6
Compare
Contributor
|
@arun-annamalai can you revert changes in the go.mod files as they are irrelevant to this PR |
arun-annamalai
force-pushed
the
java17makefile
branch
from
ca30dc6 to
8342829
Compare
Contributor
Author
|
Reverted Go mod changes and put out another revision. Thank you for noticing. |
arun-annamalai
force-pushed
the
java17makefile
branch
from
836cff7 to
0cef2b1
Compare
Contributor
Author
|
Could someone with merge permissions merge this in for me? |
serkan-ozal
approved these changes
Jan 22, 2025
Contributor
|
@tylerbenson are we good to merge this? |
tylerbenson
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1666