Skip to content

Deprecate configureTracerProvider and use configureTracer in tests #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serkan-ozal merged 1 commit into from
Apr 14, 2025
Merged

Deprecate configureTracerProvider and use configureTracer in tests #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions nodejs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions nodejs/packages/layer/src/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ declare global {
defaultSdkRegistration: SDKRegistrationConfig,
): SDKRegistrationConfig;
function configureTracer(defaultConfig: TracerConfig): TracerConfig;
/**
* @deprecated please use {@link configureTracer} instead.
*/
function configureTracerProvider(tracerProvider: BasicTracerProvider): void;

// No explicit metric type here, but "unknown" type.
Expand Down
6 changes: 4 additions & 2 deletions nodejs/packages/layer/test/handler.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ describe('when loading ESM module', async () => {
const initializeHandler = async (handler) => {
process.env._HANDLER = handler;

global.configureTracerProvider = (tracerProvider) => {
tracerProvider.addSpanProcessor(new BatchSpanProcessor(memoryExporter));
global.configureTracer = (_) => {
return {
spanProcessors: [new BatchSpanProcessor(memoryExporter)],
};
};
global.configureMeter = (_) => { {} };
global.configureMeterProvider = (_) => {};
Expand Down
6 changes: 4 additions & 2 deletions nodejs/packages/layer/test/handler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ describe('when loading ESM module', async () => {
const initializeHandler = async (handler: string) => {
process.env._HANDLER = handler;

global.configureTracerProvider = tracerProvider => {
tracerProvider.addSpanProcessor(new BatchSpanProcessor(memoryExporter));
global.configureTracer = _ => {
return {
spanProcessors: [new BatchSpanProcessor(memoryExporter)],
};
};
global.configureMeter = _ => {
return {} as any;
Expand Down