Skip to content

Conversation

@biddyfiddy
Copy link
Contributor

@biddyfiddy biddyfiddy requested a review from a team as a code owner May 14, 2025 19:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@biddyfiddy
Copy link
Contributor Author

bump

@biddyfiddy
Copy link
Contributor Author

@xuan-cao-swi is it possible to have this reviewed?

@serkan-ozal
Copy link
Contributor

Hi @biddyfiddy,

Sorry for late responses. Actually, there are other places in the collector (https://github.com/open-telemetry/opentelemetry-lambda/tree/main/collector) where we use Go version 1.23.1. Should those versions need to be updated?

@biddyfiddy
Copy link
Contributor Author

Hi @biddyfiddy,

Sorry for late responses. Actually, there are other places in the collector (https://github.com/open-telemetry/opentelemetry-lambda/tree/main/collector) where we use Go version 1.23.1. Should those versions need to be updated?

thanks! i updated the other go.mod files.

@maxday
Copy link
Member

maxday commented May 24, 2025

idea: it could be great to automate this kind of bump thanks to a GitHub action?
Unfortunately dependabot does not support go version upgrade in go.mod files (source: dependabot/dependabot-core#9057) but it seems that this 3-rd party actions does that: https://github.com/030/gomod-go-version-updater-action. WDYT?

@serkan-ozal
Copy link
Contributor

Thanks @biddyfiddy, even though caret version is used, can you also update the version here: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/.github/workflows/release-layer-collector.yml#L36

@biddyfiddy
Copy link
Contributor Author

idea: it could be great to automate this kind of bump thanks to a GitHub action? Unfortunately dependabot does not support go version upgrade in go.mod files (source: dependabot/dependabot-core#9057) but it seems that this 3-rd party actions does that: https://github.com/030/gomod-go-version-updater-action. WDYT?

This might be better as an improvement outside of this PR. My intentions are to quickly bump the version so we can use it in our downstream dependencies.

@biddyfiddy
Copy link
Contributor Author

Thanks @biddyfiddy, even though caret version is used, can you also update the version here: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/.github/workflows/release-layer-collector.yml#L36

done

@maxday
Copy link
Member

maxday commented May 28, 2025

This might be better as an improvement outside of this PR. My intentions are to quickly bump the version so we can use it in our downstream dependencies.

Sure! If that sounds good to you @serkan-ozal I can open an issue and draft a PR for this. The less manual work we need to do to stay evergreen the better is it IMO :)

@serkan-ozal
Copy link
Contributor

Hi @maxday, sure, sounds good. let's go ahead!

@serkan-ozal
Copy link
Contributor

Thanks for taking care of every comment @biddyfiddy

@serkan-ozal serkan-ozal merged commit 3af180d into open-telemetry:main May 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants