fix: token permissions #1836
Merged
fix: token permissions #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkan-ozal
approved these changes
May 31, 2025
tylerbenson
added
the
github_actions
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of those PRs : #1824 and #1823
This PRs will bump our score from 0 to 10 for the Token-Permissions part.
I've merged this commit on my fork to see that it indeed fix all the security issues detected by OSSF.
(source: https://scorecard.dev/viewer/?uri=github.com/maxday/opentelemetry-lambda where this commit has been merged to my main branch)
This is important because we now are restricting the write permission at the job level (as recommended here: https://github.com/ossf/scorecard/blob/cd152cb6742c5b8f2f3d2b5193b41d9c50905198/docs/checks.md#token-permissions)