build: add typeRoots to tsconfig as fix for possible conflicts with other types in repositories with this repo as submodule #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther types in repositories with this repo as submodule
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent type conflicts between mocha and jest types when the OpenTelemetry Lambda repository is used as a submodule in other repositories (e.g., AWS CDK infrastructure repositories) by explicitly setting typeRoots in the TypeScript configuration.
Key Changes
- Added
typeRootsconfiguration totsconfig.base.jsonto restrict TypeScript to only load types from the localnode_modules/@typesdirectory - This prevents TypeScript from searching parent directories for type definitions when used as a submodule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
serkan-ozal
approved these changes
Nov 27, 2025
wpessers
approved these changes
Nov 27, 2025
wladyslawczyzewski
deleted the
fix-building-nodejs-package-as-submodule-in-other-repositories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the OpenTelemetry Lambda collector and wrapper as a submodule of other repositories (for example as part of AWS CDK infrastructure repository)
mochatypes may conflict withjesttypes. Therefore some additional changes required to explicitly set the type roots for nodejs's lambda wrapper.