ta: inline tls config for config generation#4146
Merged
swiatekm merged 10 commits intoopen-telemetry:mainfrom Jul 8, 2025
Merged
ta: inline tls config for config generation#4146swiatekm merged 10 commits intoopen-telemetry:mainfrom
swiatekm merged 10 commits intoopen-telemetry:mainfrom
Conversation
fixes: #3724 Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Contributor
ta could come up after the collector which could cause it to go into a clbo. this race condition can make the metrics endpoint unavailable and cause the test to be flaky. Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
swiatekm
reviewed
Jun 30, 2025
Contributor
swiatekm
left a comment
swiatekm
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix! I have one request in regards to the chainsaw tests before I'll approve, but both the change and the test logic look valid to me.
tests/e2e-ta-collector-mtls/ta-collector-mtls-scrapeconfig-node/01-install.yaml
Show resolved
Hide resolved
Signed-off-by: Charlie Le <charlie_le@apple.com>
swiatekm
reviewed
Jul 1, 2025
tests/e2e-ta-collector-mtls/ta-collector-mtls-scrapeconfig-node/chainsaw-test.yaml
Outdated
Show resolved
Hide resolved
swiatekm
approved these changes
Jul 2, 2025
Contributor
swiatekm
left a comment
swiatekm
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: