Fix flaky pod Watcher test in target allocator#4180
Merged
swiatekm merged 1 commit intoopen-telemetry:mainfrom Jul 11, 2025
Merged
Fix flaky pod Watcher test in target allocator#4180swiatekm merged 1 commit intoopen-telemetry:mainfrom
swiatekm merged 1 commit intoopen-telemetry:mainfrom
Conversation
swiatekm
added
Skip Changelog
The root cause of the flakiness was that the fake client we're using doesn't support resource versions. Informers rely on these to avoid race conditions when processing the initial object list. The flaky tests were caused by this race condition. I've fixed this by having the tests check whether the informer event handlers have synced before changing objects using the client. I've also had the test pass around a pointer to the watcher rather than the whole struct.
swiatekm
force-pushed
the
test/fix-flaky-pod-watcher-test
branch
from
0c89851 to
4eda9c5
Compare
Contributor
iblancasa
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of the flakiness was that the fake client we're using doesn't support resource versions. Informers rely on these to avoid race conditions when processing the initial object list. The flaky tests were caused by this race condition. I've fixed this by having the tests check whether the informer event handlers have synced before changing objects using the client.
I've also had the test pass around a pointer to the watcher rather than the whole struct.
Closes #4184.