bugfix: validate maxReplica when minReplica is set for autoscaler

[carsontham]

Description:

bugfix - added a validation check when minReplica is set but maxReplica is not. This returns an error and does not allow the number of replicas to be updated.

Link to tracking Issue(s):

• Resolves: Setting only autoscaler.minReplicas without maxReplicas results in an attempt to create an HPA with maxReplicas = 0 #4160

Testing:

• added unit test for this change
• also tested the fix locally, by trying to update autoscaler without maxReplica when minReplica is set:

error: opentelemetrycollectors.opentelemetry.io "simplest" could not be patched: admission webhook "vopentelemetrycollectorcreateupdatebeta.kb.io" denied the request: spec.maxReplica must be set when spec.minReplica is set

Documentation:

[github-actions]

E2E Test Results

 33 files  ±0  221 suites  ±0   3h 44m 7s ⏱️ - 22m 14s
 85 tests ±0   85 ✅ ±0  0 💤 ±0  0 ❌ ±0 
225 runs  ±0  225 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 248da5f. ± Comparison against base commit c5dd81b.

♻️ This comment has been updated with latest results.