fix(target-allocator): Stop pretending to be Prometheus 2.55.1#4218
Merged
jaronoff97 merged 1 commit intoopen-telemetry:mainfrom Jul 25, 2025
Conversation
Signed-off-by: Christian Ciach <christian.ciach@gmail.com>
Contributor
Author
swiatekm
approved these changes
Jul 25, 2025
Contributor
swiatekm
left a comment
swiatekm
left a comment
There was a problem hiding this comment.
LGTM, thank you for cleaning this up.
jaronoff97
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Stop pretending to be Prometheus 2.55.1 when generating the Scrape-Configs using PrometheusCRs.
I mentioned in #4000 (comment) that this hardcoded version number results in some ugly warnings. I don't know if there are any worse consequences than just the warnings.
Anyway, @swiatekm agreed that this hardcoded version should be removed in #4000 (comment).
Link to tracking Issue(s): #4000 (comment).
Testing:
No testing has been performed. I don't know why the version has been set to 2.55.1 to begin with, and I don't know what happens when we stop doing this. That's why this PR is a draft.
Documentation: