feat(targetallocator): Expose missing Prometheus CR fields#4767
feat(targetallocator): Expose missing Prometheus CR fields#4767alex5517 wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
I haven't fully reviewed your PR, but you should take note of the conversation here: #3573 (comment) and ensure you're setting the right defaults for selectors to avoid breaking changes. |
E2E Test Results 34 files ±0 227 suites ±0 2h 16m 0s ⏱️ + 8m 53s For more details on these failures, see this check. Results for commit 100ee8a. ± Comparison against base commit b277e27. ♻️ This comment has been updated with latest results. |
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
|
Ah thanks for pointing that out. I have updated the PR to add the |
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
|
e2e tests are fixed (works on my machine) - I realized I had an oversight with how step-02 was handling the new selectors, so I reorganized things a bit. Step-02 now verify the default empty selectors, and step-03 tests the actual namespace selector logic for scrape configs. |
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
|
@swiatekm - Sorry about that, missed the |
Description:
This PR adds several missing fields to the
prometheusCRconfiguration within theTargetAllocatorandOpenTelemetryCollectorAPIs (v1beta1).Currently, the underlying Target Allocator binary supports these Prometheus Custom Resource specifications, but they were not exposed via the Operator's API. This change achieves feature parity by exposing the following fields:
evaluationIntervalscrapeProtocolspodMonitorNamespaceSelectorserviceMonitorNamespaceSelectorscrapeConfigNamespaceSelectorprobeNamespaceSelectorLink to tracking Issue(s): N/A
Testing:
tests/e2e-targetallocator/targetallocator-prometheuscr(02-install.yamland02-assert.yaml) to deploy av1beta1Collector with all new fields populated, asserting that they correctly serialize into the resultingtargetallocator.yamlConfigMap payload.make testlocally to ensure all tests pass.Documentation:
make updateto automatically regeneratedocs/api/opentelemetrycollectors.mdanddocs/api/targetallocators.md..chloggenYAML entry for the release notes.