[v1alpha1] move webhook types to internal/webhook#4837
Merged
swiatekm merged 1 commit intoopen-telemetry:mainfrom Mar 10, 2026
Merged
[v1alpha1] move webhook types to internal/webhook#4837swiatekm merged 1 commit intoopen-telemetry:mainfrom
swiatekm merged 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
E2E Test Results 34 files ±0 247 suites ±0 2h 6m 49s ⏱️ -45s For more details on these failures, see this check. Results for commit 32b5828. ± Comparison against base commit 91deeae. ♻️ This comment has been updated with latest results. |
jaronoff97
approved these changes
Mar 10, 2026
Contributor
jaronoff97
left a comment
jaronoff97
left a comment
There was a problem hiding this comment.
I think this is a reasonable breaking change as it's almost a bug fix in that users cannot currently depend on these types despite that being their goal/expectation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Feedback from #4201
By moving the webhooks to an internal package, we can depend on the types defined in the CRD.