Skip to content

Conversation

@thomasbeaujean
Copy link
Contributor

Since OpenSwoole: 4.4.0,
the method Coroutine::list is available: https://openswoole.com/docs/modules/swoole-coroutine

In the 22 version, the method Coroutine::listCoroutines does not exist.

@thomasbeaujean thomasbeaujean requested a review from a team September 16, 2024 12:56
@welcome
Copy link

welcome bot commented Sep 16, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (e5a13ce) to head (cf3fcc0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Context/Swoole/src/SwooleContextHandler.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #294   +/-   ##
=========================================
  Coverage     82.68%   82.68%           
- Complexity      948      949    +1     
=========================================
  Files            89       89           
  Lines          3807     3807           
=========================================
  Hits           3148     3148           
  Misses          659      659           
Flag Coverage Δ
Aws 85.75% <ø> (ø)
Context/Swoole 0.00% <0.00%> (ø)
Instrumentation/CodeIgniter 73.94% <ø> (ø)
Instrumentation/ExtAmqp 89.58% <ø> (ø)
Instrumentation/Guzzle 69.73% <ø> (ø)
Instrumentation/HttpAsyncClient 81.33% <ø> (ø)
Instrumentation/IO 70.90% <ø> (ø)
Instrumentation/MongoDB 77.33% <ø> (ø)
Instrumentation/OpenAIPHP 86.82% <ø> (ø)
Instrumentation/PDO 89.56% <ø> (ø)
Instrumentation/Psr14 78.12% <ø> (ø)
Instrumentation/Psr15 93.50% <ø> (ø)
Instrumentation/Psr18 82.08% <ø> (ø)
Instrumentation/Slim 86.95% <ø> (ø)
Instrumentation/Symfony 89.03% <ø> (ø)
Instrumentation/Yii 77.77% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 32.14% <ø> (ø)
Shims/OpenTracing 92.99% <ø> (ø)
Symfony 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Context/Swoole/src/SwooleContextHandler.php 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a13ce...cf3fcc0. Read the comment docs.

@brettmc brettmc merged commit c549d0f into open-telemetry:main Sep 17, 2024
96 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants