Skip to content

Fix broken Serializer when using Laravel Illuminate\Queue\LuaScripts #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Fix broken Serializer when using Laravel Illuminate\Queue\LuaScripts #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa073dc
Fix broken Serializer when using Laravel Illuminate\Queue\LuaScripts
gdaszuta Oct 22, 2024
11c4078
Add test for array-type redis parameters
gdaszuta Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Instrumentation/Laravel/src/Watchers/RedisCommand/Serializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ public static function serializeCommand(string $command, array $params): string
$paramsToSerialize[] = '[' . (count($params) - $paramsToSerializeNum) . ' other arguments]';
}

// In some cases (for example when using LUA scripts) arrays are valid parameters
$paramsToSerialize = array_map(function($param) { return is_array($param) ? json_encode($param) : $param; }, $paramsToSerialize);

return $command . ' ' . implode(' ', $paramsToSerialize);
}
}
3 changes: 3 additions & 0 deletions src/Instrumentation/Laravel/tests/Unit/Watches/RedisCommand/SerializerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,8 @@ public function serializeCases(): iterable

// Serialize all params
yield ['DEL', ['param1', 'param2', 'param3', 'param4'], 'DEL param1 param2 param3 param4'];

// Parameters of array type
yield ['EVAL', ['param1', 'param2', ['arg1', 'arg2']], 'EVAL param1 param2 ["arg1","arg2"]'];
}
}
Loading