Skip to content

Conversation

@intuibase
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Oct 29, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@intuibase intuibase marked this pull request as ready for review October 29, 2024 15:10
@intuibase intuibase requested a review from a team as a code owner October 29, 2024 15:10
@brettmc
Copy link
Contributor

brettmc commented Oct 30, 2024

LGTM - can you also please add an entry to the top-level .gitsplit.yml ? Required to do a subtree split for packagist.

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 91.02041% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (0a41216) to head (aeac36d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/Instrumentation/Curl/src/CurlInstrumentation.php 91.02% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #313      +/-   ##
============================================
- Coverage     79.85%   79.12%   -0.73%     
+ Complexity      887      676     -211     
============================================
  Files            85       67      -18     
  Lines          3495     2822     -673     
============================================
- Hits           2791     2233     -558     
+ Misses          704      589     -115     
Flag Coverage Δ
Aws 85.55% <ø> (ø)
Instrumentation/CakePHP 20.00% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 91.02% <91.02%> (?)
Instrumentation/ExtAmqp ?
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 81.25% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 76.31% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (?)
Instrumentation/PDO 89.95% <ø> (?)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 93.82% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 81.15% <ø> (ø)
Instrumentation/Psr3 ?
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.89% <ø> (ø)
Instrumentation/Symfony 88.70% <ø> (?)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog ?
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (?)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/Instrumentation/Curl/src/CurlInstrumentation.php 91.02% <91.02%> (ø)

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a41216...aeac36d. Read the comment docs.

@intuibase intuibase requested a review from brettmc October 30, 2024 09:27
@brettmc
Copy link
Contributor

brettmc commented Oct 30, 2024

@brettmc brettmc merged commit 27a188b into open-telemetry:main Oct 30, 2024
97 of 122 checks passed
@brettmc
Copy link
Contributor

brettmc commented Oct 30, 2024

@intuibase intuibase deleted the curl_auto_instrumentation branch October 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants