Drop support for PHP 7.4 and 8.0, introduce support for PHP 8.4, fix semconv deprecations by intuibase · Pull Request #315 · open-telemetry/opentelemetry-php-contrib

intuibase · 2024-11-05T16:28:25Z

No description provided.

codecov · 2024-11-05T16:31:44Z

Codecov Report

Attention: Patch coverage is 58.57143% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (2d17302) to head (17509ba).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...rumentation/Symfony/src/SymfonyInstrumentation.php	0.00%	5 Missing ⚠️
src/Context/Swoole/src/SwooleContextStorage.php	0.00%	3 Missing ⚠️
...tion/Laravel/src/Hooks/Illuminate/Queue/Worker.php	0.00%	3 Missing ⚠️
src/Instrumentation/PDO/src/PDOInstrumentation.php	0.00%	3 Missing ⚠️
src/Context/Swoole/src/SwooleContextHandler.php	0.00%	2 Missing ⚠️
...ation/ExtRdKafka/src/ExtRdKafkaInstrumentation.php	50.00%	2 Missing ⚠️
...oks/Illuminate/Foundation/Console/ServeCommand.php	0.00%	2 Missing ⚠️
src/Instrumentation/MySqli/src/MySqliTracker.php	50.00%	2 Missing ⚠️
...c/Instrumentation/Slim/src/SlimInstrumentation.php	0.00%	2 Missing ⚠️
...c/Instrumentation/Curl/src/CurlInstrumentation.php	90.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #315      +/-   ##
============================================
- Coverage     80.67%   80.44%   -0.24%     
- Complexity     1295     1507     +212     
============================================
  Files           114      129      +15     
  Lines          5486     6182     +696     
============================================
+ Hits           4426     4973     +547     
- Misses         1060     1209     +149

Flag	Coverage Δ
Aws	`85.55% <100.00%> (?)`
Context/Swoole	`0.00% <0.00%> (?)`
Instrumentation/CakePHP	`20.27% <ø> (ø)`
Instrumentation/CodeIgniter	`73.77% <ø> (ø)`
Instrumentation/Curl	`90.42% <90.00%> (-0.25%)`	⬇️
Instrumentation/ExtAmqp	`89.26% <100.00%> (ø)`
Instrumentation/ExtRdKafka	`86.23% <50.00%> (-1.50%)`	⬇️
Instrumentation/Guzzle	`69.51% <ø> (ø)`
Instrumentation/HttpAsyncClient	`78.31% <ø> (ø)`
Instrumentation/IO	`70.68% <ø> (ø)`
Instrumentation/Laravel	`62.17% <38.46%> (ø)`
Instrumentation/MongoDB	`74.28% <100.00%> (+0.24%)`	⬆️
Instrumentation/MySqli	`95.81% <50.00%> (-0.28%)`	⬇️
Instrumentation/OpenAIPHP	`87.31% <ø> (ø)`
Instrumentation/PDO	`90.15% <63.63%> (?)`
Instrumentation/Psr14	`77.14% <ø> (ø)`
Instrumentation/Psr15	`89.41% <ø> (ø)`
Instrumentation/Psr16	`97.56% <ø> (ø)`
Instrumentation/Psr18	`77.77% <ø> (ø)`
Instrumentation/Psr3	`59.49% <100.00%> (ø)`
Instrumentation/Psr6	`97.67% <ø> (ø)`
Instrumentation/Slim	`86.30% <50.00%> (-0.60%)`	⬇️
Instrumentation/Symfony	`84.93% <0.00%> (ø)`
Instrumentation/Yii	`77.68% <ø> (ø)`
Logs/Monolog	`100.00% <ø> (ø)`
Propagation/ServerTiming	`100.00% <ø> (ø)`
Propagation/TraceResponse	`100.00% <ø> (ø)`
ResourceDetectors/Azure	`91.66% <ø> (ø)`
ResourceDetectors/Container	`93.02% <ø> (ø)`
Sampler/RuleBased	`33.51% <ø> (ø)`
Shims/OpenTracing	`92.45% <ø> (ø)`
Symfony	`87.81% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/Aws/src/AwsSdkInstrumentation.php	`48.07% <100.00%> (ø)`
src/Aws/src/Ecs/Detector.php	`92.38% <100.00%> (ø)`
src/Aws/src/Eks/DataProvider.php	`100.00% <100.00%> (ø)`
src/Aws/src/Xray/IdGenerator.php	`100.00% <ø> (ø)`
src/Aws/src/Xray/Propagator.php	`100.00% <ø> (ø)`
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php	`78.70% <ø> (ø)`
...tion/CodeIgniter/src/ResponsePropagationSetter.php	`0.00% <ø> (ø)`
...rumentation/ExtAmqp/src/ExtAmqpInstrumentation.php	`89.26% <100.00%> (ø)`
...strumentation/Guzzle/src/GuzzleInstrumentation.php	`74.02% <ø> (ø)`
...AsyncClient/src/HttpAsyncClientInstrumentation.php	`76.92% <ø> (ø)`
... and 52 more

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d17302...17509ba. Read the comment docs.

intuibase · 2024-11-05T16:34:55Z

src/Instrumentation/Laravel/src/Watchers/QueryWatcher.php

-            TraceAttributes::DB_OPERATION => $operationName,
+            TraceAttributes::DB_NAMESPACE => $query->connection->getDatabaseName(),
+            TraceAttributes::DB_OPERATION_NAME => $operationName,
+            /** @phan-suppress-next-line PhanDeprecatedClassConstant */


I have no idea what to do if there is no replacement

I guess drop it is the best option

brettmc · 2024-11-07T13:14:32Z

These changes look sensible, but I suspect that the semantic convention ones will run into the moratorium on changing produced telemetry.

I don't fully understand the reasoning, but it's becoming a real pain for us: we created a bunch of packages (auto-instrumentation and such) at around semconv 1.24/1.25, and those packages are seemingly stuck on those versions until that moratorium is lifted. But in the meantime, new semconv versions have been released which deprecate some of those semconvs, and our static analysis tools complain.

src/Context/Swoole/src/SwooleContextStorage.php

brettmc · 2025-02-08T22:32:18Z

Are you happy with this now? I think I have also touched some of the same code in #327 (the build is quite green now), but let's merge this one first and I'll take care of any conflicts in my PR.

src/Logs/Monolog/src/Handler.php

intuibase · 2025-02-14T08:49:59Z

@brettmc @ChrisLightfootWild I think PR is ready for your review.
If you will decide to merge, please remove intermediate commit messages - they're not meaningful.

brettmc · 2025-02-16T23:23:46Z

src/Instrumentation/Laravel/src/Watchers/LogWatcher.php

        $record = (new LogRecord($log->message))
            ->setSeverityText($log->level)
-            ->setSeverityNumber(Psr3::severityNumber($log->level))
+            ->setSeverityNumber(Severity::fromPsr3($log->level))


@ChrisLightfootWild I think this requires API 1.1.0 and therefore dropping 8.0 support - how does that sound?

Yeah, I've got the same dependency bumps in #269 so that's fine by me.

Would be good to maybe get this in first and then see if I can update my branch and move that forward a bit.

ok, will merge!

Fixed a bit of warnings and deprecations

f8f40cb

intuibase requested a review from a team as a code owner November 5, 2024 16:28

intuibase commented Nov 5, 2024

View reviewed changes

brettmc mentioned this pull request Jan 8, 2025

Ci fixes #323

Closed

brettmc reviewed Jan 8, 2025

View reviewed changes

src/Context/Swoole/src/SwooleContextStorage.php Show resolved Hide resolved

intuibase mentioned this pull request Feb 3, 2025

Remove deprecated PHP versions from opentelemetry-contrib elastic/elastic-otel-php#156

Closed

Merge branch 'main' into fix_issues

1eb4272

intuibase changed the title ~~Fixed a bit of warnings and deprecations~~ Drop support for PHP 7.4 and 8.0, introduce support for PHP 8.4, fix semconv deprecations Feb 7, 2025

intuibase added 2 commits February 12, 2025 09:59

Dropped support for PHP 7.4 and 8.0. Intorduced support for PHP 8.4

2a15d9d

Merge branch 'main' into fix_issues

66d1a18

intuibase force-pushed the fix_issues branch from 6b997f2 to 66d1a18 Compare February 12, 2025 09:14

ChrisLightfootWild reviewed Feb 12, 2025

View reviewed changes

src/Logs/Monolog/src/Handler.php Outdated Show resolved Hide resolved

intuibase added 12 commits February 12, 2025 12:50

Set revision psalm to 6.4.0, more suppressions

8a290be

next bunch of psalm fixes

3c997b1

next bunch of psalm fixes

a5d0f88

next bunch of psalm fixes

8aa437e

next bunch of psalm fixes

475693e

next bunch of static analysis fixes

b226c25

next bunch of static analysis fixes

2845809

next bunch of static analysis fixes

e0804bb

Curl instrumentation fix

4d37b4d

surrpressed deprecation messages

0ae1898

surrpressed deprecation messages

70a80c9

updated packages generating deprecated warnings

17509ba

intuibase requested review from ChrisLightfootWild and brettmc February 14, 2025 08:47

brettmc reviewed Feb 16, 2025

View reviewed changes

ChrisLightfootWild mentioned this pull request Feb 24, 2025

[Laravel] Allow Laravel 12 #333

Merged

brettmc approved these changes Feb 25, 2025

View reviewed changes

brettmc merged commit 261c2d0 into open-telemetry:main Feb 25, 2025
123 of 124 checks passed

intuibase deleted the fix_issues branch February 28, 2025 15:58

intuibase mentioned this pull request Apr 8, 2025

REQUEST: New membership for @intuibase open-telemetry/community#2647

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Drop support for PHP 7.4 and 8.0, introduce support for PHP 8.4, fix semconv deprecations#315

Drop support for PHP 7.4 and 8.0, introduce support for PHP 8.4, fix semconv deprecations#315
brettmc merged 16 commits intoopen-telemetry:mainfrom
intuibase:fix_issues

intuibase commented Nov 5, 2024

Uh oh!

codecov bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

intuibase Nov 5, 2024

Uh oh!

brettmc Nov 7, 2024

Uh oh!

brettmc commented Nov 7, 2024

Uh oh!

Uh oh!

brettmc commented Feb 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

intuibase commented Feb 14, 2025

Uh oh!

brettmc Feb 16, 2025

Uh oh!

ChrisLightfootWild Feb 24, 2025

Uh oh!

brettmc Feb 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

intuibase commented Nov 5, 2024

Uh oh!

codecov bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

intuibase Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

brettmc Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

brettmc commented Nov 7, 2024

Uh oh!

Uh oh!

brettmc commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

intuibase commented Feb 14, 2025

Uh oh!

brettmc Feb 16, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisLightfootWild Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

brettmc Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 5, 2024 •

edited

Loading

brettmc commented Feb 8, 2025 •

edited

Loading