Skip to content

Conversation

@javespi
Copy link
Contributor

@javespi javespi commented Feb 6, 2025

Error running on PHP 8.4:

OpenTelemetry\Contrib\Instrumentation\MongoDB\MongoDBInstrumentation::register(): Implicitly marking parameter $commandSerializer as nullable is deprecated, the explicit nullable type must be used instead

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations. This requires PHP 7.1 (we currently require PHP >=7.4), so we are safe

See:

@javespi javespi requested a review from a team as a code owner February 6, 2025 15:12
@welcome
Copy link

welcome bot commented Feb 6, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 6, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.62%. Comparing base (ee99079) to head (1325029).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rumentation/MongoDB/src/MongoDBInstrumentation.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #328      +/-   ##
============================================
- Coverage     85.87%   85.62%   -0.25%     
+ Complexity     1081      621     -460     
============================================
  Files            73       37      -36     
  Lines          4480     2588    -1892     
============================================
- Hits           3847     2216    -1631     
+ Misses          633      372     -261     
Flag Coverage Δ
Instrumentation/CakePHP 20.00% <ø> (ø)
Instrumentation/CodeIgniter ?
Instrumentation/Curl 90.66% <ø> (ø)
Instrumentation/Guzzle ?
Instrumentation/HttpAsyncClient ?
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 72.64% <0.00%> (ø)
Instrumentation/MySqli 96.10% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 89.95% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 93.82% <ø> (ø)
Instrumentation/Psr16 ?
Instrumentation/Psr18 81.15% <ø> (ø)
Instrumentation/Psr6 ?
Instrumentation/Slim ?
Instrumentation/Symfony 88.70% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rumentation/MongoDB/src/MongoDBInstrumentation.php 20.00% <0.00%> (ø)

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee99079...1325029. Read the comment docs.

@brettmc brettmc merged commit 3fd3101 into open-telemetry:main Feb 7, 2025
64 of 122 checks passed
@javespi javespi deleted the implicit-null-php84 branch February 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants