Skip to content

Conversation

@satdeveloping
Copy link
Contributor

This PR replicates changes made in the wrong repository: opentelemetry-php/contrib-sampler-rulebased#1

@satdeveloping satdeveloping requested a review from a team as a code owner February 11, 2025 08:23
@welcome
Copy link

welcome bot commented Feb 11, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: satdeveloping / name: Stuart Taylor (f794a6c)

@satdeveloping satdeveloping force-pushed the chore/dep-updates branch 2 times, most recently from d982dde to b9cfeef Compare February 11, 2025 08:28
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (f284027) to head (f794a6c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #329      +/-   ##
============================================
- Coverage     85.16%   81.43%   -3.73%     
- Complexity      589      637      +48     
============================================
  Files            35       48      +13     
  Lines          2339     2521     +182     
============================================
+ Hits           1992     2053      +61     
- Misses          347      468     +121     
Flag Coverage Δ
Instrumentation/CakePHP 20.00% <ø> (ø)
Instrumentation/Curl 90.66% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 72.64% <ø> (ø)
Instrumentation/MySqli 96.10% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 93.82% <ø> (ø)
Instrumentation/Psr18 81.15% <ø> (ø)
Instrumentation/Symfony 88.70% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (?)
Shims/OpenTracing 92.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f284027...f794a6c. Read the comment docs.

@brettmc
Copy link
Contributor

brettmc commented Feb 11, 2025

LGTM, thanks @satdeveloping !

@brettmc brettmc merged commit 96f0d0c into open-telemetry:main Feb 11, 2025
65 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants