-
Notifications
You must be signed in to change notification settings - Fork 117
fix: resolve PDO WeakMap warning #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve PDO WeakMap warning #334
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
|
ba88de5 to
072800c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=========================================
Coverage 80.42% 80.42%
+ Complexity 1502 1500 -2
=========================================
Files 128 128
Lines 6176 6176
=========================================
Hits 4967 4967
Misses 1209 1209 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@ycchuang99 can you please check the psalm errors reported against PDO? I think they're related to this fix. |
|
@brettmc Thanks for the reminder! I will take a look at it. |
072800c to
11fcb91
Compare
Replace comparison operators with null coalescing operator to fix undefined array error. Fixes open-telemetry/opentelemetry-php#1529
11fcb91 to
fd5017d
Compare
|
Hi @brettmc, I've fixed the Psalm errors, but I'm not sure if it's the proper way to resolve them. Could you review the changes and let me know if any adjustments are needed? Thanks! |
Replace comparison operators with null coalescing operator to fix undefined array error.
Fixes #1529