fix: Track attributes for new PDO subclasses & span hierarchy #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
============================================
+ Coverage 79.45% 79.70% +0.24%
- Complexity 1772 1787 +15
============================================
Files 137 137
Lines 7568 7626 +58
============================================
+ Hits 6013 6078 +65
+ Misses 1555 1548 -7 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cedricziel
changed the title
brettmc
reviewed
Mar 29, 2025
brettmc
approved these changes
Mar 29, 2025
bobstrecansky
approved these changes
Apr 1, 2025
Nevay
reviewed
Apr 1, 2025
cedricziel
force-pushed
the
pdo-subclasses
branch
from
0a52bb3 to
782f9dc
Compare
intuibase
approved these changes
Apr 8, 2025
6 tasks
|
@cedricziel - is this ready to merge? |
|
@brettmc ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds connection tracking to the new pdo subclasses in PHP 8.4
It also fixes an issue where the hierarchy of a trace was not correctly maintained.
Also combines attribute tracking into one cohesive method.
Fixes: open-telemetry/opentelemetry-php#1469
Context: https://www.php.net/releases/8.4/en.php#pdo_driver_specific_subclasses