-
Couldn't load subscription status.
- Fork 117
feat: track Eloquent ORM #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
============================================
- Coverage 80.83% 80.48% -0.35%
- Complexity 1502 1510 +8
============================================
Files 128 129 +1
Lines 6183 6370 +187
============================================
+ Hits 4998 5127 +129
- Misses 1185 1243 +58 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
src/Instrumentation/Laravel/tests/Integration/LaravelInstrumentationTest.php
Outdated
Show resolved
Hide resolved
…tationTest.php Co-authored-by: Chris Lightfoot-Wild <[email protected]>
|
I moved the eval to a fixture class. Should be good now. |
src/Instrumentation/Symfony/src/Propagation/EnvelopeContextPropagator.php
Outdated
Show resolved
Hide resolved
1c185dc to
321140b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
This tracks the model interactions and allows a user to understand how the app interacts with the model classes.
It should be considered to to remove the event-based recording of SQL statements and fold them into this, or remove the sql bits completely and rely on the PDO instrumentation.