Skip to content

Conversation

@mitchierichie
Copy link
Contributor

@mitchierichie mitchierichie commented Apr 21, 2025

fix CI issues from #357

@brettmc

@mitchierichie mitchierichie requested a review from a team as a code owner April 21, 2025 05:17
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (d6f5e3e) to head (d32aa6a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #359      +/-   ##
============================================
+ Coverage     81.69%   82.27%   +0.57%     
- Complexity     1664     1799     +135     
============================================
  Files           125      134       +9     
  Lines          7223     7628     +405     
============================================
+ Hits           5901     6276     +375     
- Misses         1322     1352      +30     
Flag Coverage Δ
Aws 92.59% <100.00%> (?)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 92.77% <ø> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 86.23% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 64.11% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 94.23% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.30% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)
Utils/Test 88.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Aws/src/AwsSdkInstrumentation.php 95.55% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f5e3e...d32aa6a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mitchierichie
Copy link
Contributor Author

@brettmc any idea what's up with the failing MongoDB steps? I am sure I didn't touch that 😅

@brettmc
Copy link
Contributor

brettmc commented Apr 21, 2025

any idea what's up with the failing MongoDB steps?

Ignore, there's already a PR for it.

There's also a linting issue to be resolved: https://github.com/open-telemetry/opentelemetry-php-contrib/actions/runs/14568091222/job/40860421500?pr=359

If you're following our development process, make style should resolve that one.

@mitchierichie mitchierichie force-pushed the patch-1 branch 2 times, most recently from 224f2f4 to c0e2707 Compare April 21, 2025 13:45
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@mitchierichie mitchierichie force-pushed the patch-1 branch 2 times, most recently from 1f59788 to 55eef08 Compare April 21, 2025 13:51
@mitchierichie
Copy link
Contributor Author

@brettmc alright, thanks for your help.

I think everything should be passing now, although coincidentally, it looks like the checks didn't run the last time I pushed?

@brettmc brettmc closed this Apr 22, 2025
@brettmc brettmc reopened this Apr 22, 2025
@brettmc brettmc merged commit 8599ba4 into open-telemetry:main Apr 22, 2025
130 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants