Skip to content

Conversation

@mlazarov
Copy link
Contributor

@mlazarov mlazarov commented Apr 23, 2025

Fix mongo-ext requirements condition to support both ^1.13 and ^2.0 versions

@mlazarov mlazarov requested a review from a team as a code owner April 23, 2025 16:43
@welcome
Copy link

welcome bot commented Apr 23, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 23, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is broken, as I thought a single pipe still worked, but for consistency (and personal preference) the standard || (or) gets a 👍 from me.

@mlazarov
Copy link
Contributor Author

I'm not sure that this is broken, as I thought a single pipe still worked, but for consistency (and personal preference) the standard || (or) gets a 👍 from me.

Currently when I try to run composer require open-telemetry/opentelemetry-auto-mongodb I get this error:

Cannot use open-telemetry/opentelemetry-auto-mongodb's latest version 0.0.8 as it requires ext-mongodb ^1.13 which is not satisfied by your platform.

open-telemetry/opentelemetry-auto-mongodb[0.0.7, ..., 0.0.8] require ext-mongodb ^1.13 -> it has the wrong version installed (2.0.0).

May be I'm wrong but with single pipe this isn't working as expected?

@ChrisLightfootWild
Copy link
Contributor

I'm not sure that this is broken, as I thought a single pipe still worked, but for consistency (and personal preference) the standard || (or) gets a 👍 from me.

Currently when I try to run composer require open-telemetry/opentelemetry-auto-mongodb I get this error:

Cannot use open-telemetry/opentelemetry-auto-mongodb's latest version 0.0.8 as it requires ext-mongodb ^1.13 which is not satisfied by your platform.

open-telemetry/opentelemetry-auto-mongodb[0.0.7, ..., 0.0.8] require ext-mongodb ^1.13 -> it has the wrong version installed (2.0.0).

May be I'm wrong but with single pipe this isn't working as expected?

Thanks for highlighting this!

Perhaps there's some nuance here, as it notes the use of spacing for logical AND but then does also mention backwards compatibility with logical OR and |:
https://getcomposer.org/doc/articles/versions.md#version-range

Everyday is a school day; thanks for the fix 💪

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (3835977) to head (daef873).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #360   +/-   ##
=========================================
  Coverage     82.13%   82.13%           
  Complexity     1861     1861           
=========================================
  Files           137      137           
  Lines          7804     7804           
=========================================
  Hits           6410     6410           
  Misses         1394     1394           
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 92.77% <ø> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 86.23% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 64.11% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 94.23% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.30% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3835977...daef873. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit 09dd0f9 into open-telemetry:main Apr 26, 2025
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants