-
Couldn't load subscription status.
- Fork 117
Fix mongo-ext requirements condition to support both ^1.13 and ^2.0 v… #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
The committers listed above are authorized under a signed CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this is broken, as I thought a single pipe still worked, but for consistency (and personal preference) the standard || (or) gets a 👍 from me.
Currently when I try to run May be I'm wrong but with single pipe this isn't working as expected? |
Thanks for highlighting this! Perhaps there's some nuance here, as it notes the use of spacing for Everyday is a school day; thanks for the fix 💪 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=========================================
Coverage 82.13% 82.13%
Complexity 1861 1861
=========================================
Files 137 137
Lines 7804 7804
=========================================
Hits 6410 6410
Misses 1394 1394 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fix mongo-ext requirements condition to support both ^1.13 and ^2.0 versions