Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented May 13, 2025

SemConv 1.32 deprecates a couple of attributes which we use extensively:

  • code.function.name is now an FQN (including class name)
  • code.namespace is deprecated (included in code.function.name)
  • code.linenumber is deprecated and replaced with code.line.number

Updated all packages to conform, updated min semconv to 1.32, and made a couple of minor changes"

SemConv 1.32 deprecates a couple of attributes which we use extensively:
- code.function.name is now an FQN (including class name)
- code.namespace is deprecated (included in code.function.name)
- code.linenumber is deprecated and replaced with code.line.number

Updated all packages to conform, updated min semconv to 1.32, and made
a couple of minor changes"
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (1a723de) to head (7682830).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...l/src/Hooks/Illuminate/Database/Eloquent/Model.php 71.42% 4 Missing ⚠️
...nstrumentation/CakePHP/src/Hooks/CakeHookTrait.php 0.00% 2 Missing ⚠️
.../src/Hooks/Illuminate/Contracts/Console/Kernel.php 0.00% 2 Missing ⚠️
...rumentation/CakePHP/src/CakePHPInstrumentation.php 0.00% 1 Missing ⚠️
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 66.66% 1 Missing ⚠️
...mentation/Doctrine/src/DoctrineInstrumentation.php 80.00% 1 Missing ⚠️
...rumentation/ExtAmqp/src/ExtAmqpInstrumentation.php 85.71% 1 Missing ⚠️
...ation/ExtRdKafka/src/ExtRdKafkaInstrumentation.php 66.66% 1 Missing ⚠️
...strumentation/Guzzle/src/GuzzleInstrumentation.php 66.66% 1 Missing ⚠️
...AsyncClient/src/HttpAsyncClientInstrumentation.php 66.66% 1 Missing ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #369      +/-   ##
============================================
- Coverage     82.17%   81.60%   -0.58%     
+ Complexity     1870     1722     -148     
============================================
  Files           137      133       -4     
  Lines          7822     7269     -553     
============================================
- Hits           6428     5932     -496     
+ Misses         1394     1337      -57     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.40% <0.00%> (+0.13%) ⬆️
Instrumentation/CodeIgniter 73.55% <66.66%> (-0.22%) ⬇️
Instrumentation/Curl ?
Instrumentation/Doctrine 92.72% <83.33%> (-0.05%) ⬇️
Instrumentation/ExtAmqp 88.48% <85.71%> (-0.78%) ⬇️
Instrumentation/ExtRdKafka 86.11% <66.66%> (-0.13%) ⬇️
Instrumentation/Guzzle 69.13% <66.66%> (-0.38%) ⬇️
Instrumentation/HttpAsyncClient 78.04% <66.66%> (-0.27%) ⬇️
Instrumentation/IO 70.68% <50.00%> (ø)
Instrumentation/Laravel 63.91% <74.07%> (-0.20%) ⬇️
Instrumentation/MongoDB 74.28% <0.00%> (ø)
Instrumentation/MySqli 95.81% <92.30%> (ø)
Instrumentation/OpenAIPHP ?
Instrumentation/PDO 94.21% <66.66%> (-0.02%) ⬇️
Instrumentation/Psr14 76.47% <66.66%> (-0.68%) ⬇️
Instrumentation/Psr15 89.15% <80.00%> (-0.26%) ⬇️
Instrumentation/Psr16 97.50% <100.00%> (-0.07%) ⬇️
Instrumentation/Psr18 77.46% <66.66%> (-0.32%) ⬇️
Instrumentation/Psr3 67.01% <0.00%> (ø)
Instrumentation/Psr6 97.61% <100.00%> (-0.06%) ⬇️
Instrumentation/Slim 86.11% <80.00%> (-0.20%) ⬇️
Instrumentation/Symfony 84.74% <72.72%> (-0.20%) ⬇️
Instrumentation/Yii 77.50% <66.66%> (-0.19%) ⬇️
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <100.00%> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nstrumentation/Doctrine/src/AttributesResolver.php 80.95% <100.00%> (ø)
...n/Laravel/src/Hooks/Illuminate/Console/Command.php 89.65% <100.00%> (-0.35%) ⬇️
...vel/src/Hooks/Illuminate/Contracts/Http/Kernel.php 83.56% <100.00%> (-0.23%) ⬇️
...vel/src/Hooks/Illuminate/Contracts/Queue/Queue.php 68.96% <100.00%> (-0.70%) ⬇️
...n/Laravel/src/Hooks/Illuminate/Queue/SyncQueue.php 92.30% <100.00%> (-0.29%) ⬇️
...Instrumentation/Psr16/src/Psr16Instrumentation.php 97.50% <100.00%> (-0.07%) ⬇️
...c/Instrumentation/Psr6/src/Psr6Instrumentation.php 97.61% <100.00%> (-0.06%) ⬇️
...Symfony/src/OtelBundle/Console/ConsoleListener.php 59.09% <100.00%> (ø)
...rumentation/CakePHP/src/CakePHPInstrumentation.php 0.00% <0.00%> (ø)
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 78.50% <66.66%> (-0.20%) ⬇️
... and 22 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a723de...7682830. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc marked this pull request as ready for review May 13, 2025 05:01
@brettmc brettmc requested a review from a team as a code owner May 13, 2025 05:01
@brettmc
Copy link
Contributor Author

brettmc commented May 13, 2025

Note that Curl and OpenAIPHP look to be broken in main, so unrelated to this PR.

@ChrisLightfootWild ChrisLightfootWild requested a review from a team May 13, 2025 09:44
@brettmc brettmc merged commit e728534 into open-telemetry:main May 14, 2025
126 of 132 checks passed
@brettmc brettmc deleted the semconv-1.32 branch May 14, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants