update rule-based sampler to config 0.4 #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brettmc
commented
May 22, 2025
brettmc
commented
- update to work with config 0.4
- rename key to php_rule_based
- update documentation
- update to work with config 0.4 - rename key to php_rule_based - update documentation
brettmc
commented
May 22, 2025
| public function getConfig(ComponentProviderRegistry $registry, NodeBuilder $builder): ArrayNodeDefinition | ||
| { | ||
| $node = new ArrayNodeDefinition('contrib_rule_based'); | ||
| $node = $builder->arrayNode('php_rule_based'); |
There was a problem hiding this comment.
My thinking here is that this is less likely to conflict with a sampler from another SIG, given that they would be unlikely to accept the same config
bobstrecansky
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.