fix guzzle promise handling #393
Merged
+61
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain circumstances (eg Curl handler and middlewares configured such that no additional promise chaining occurs, our post transfer hook can receive an already-resolved Promise. Since it's already resolved, our extra callbacks won't be applied in a timely fashion (they're instead added to a queue and will be processed as part of a shutdown handler, if not triggered by something earlier). The upshot of this is a lot of memory being held on to for each request, and it seems that the default config when we use guzzle as our SDK exporter will trigger this. The spans for export are non-recording, so nothing user-visible happens, but the non-recording spans and promise callbacks are held in memory, seemingly forever or until shutdown. The fix for this is to check is the promise is already resolved, and if so force our extra promise to resolve.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=========================================
Coverage 82.82% 82.82%
- Complexity 1948 1949 +1
=========================================
Files 142 142
Lines 8142 8142
=========================================
Hits 6744 6744
Misses 1398 1398 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ChrisLightfootWild
approved these changes
Jun 17, 2025
bobstrecansky
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain circumstances (eg Curl handler and middlewares configured such that no additional promise chaining occurs), our post transfer hook can receive an already-resolved Promise. Since it's already resolved, our extra callbacks won't be applied in a timely fashion (they're instead added to a queue and will be processed as part of a shutdown handler, if not triggered by something earlier).
The upshot of this is a lot of memory being held on to for each request, and it seems that the default config when we use guzzle as our SDK exporter will trigger this. The spans for export are non-recording, so nothing user-visible happens, but the non-recording spans and promise callbacks are held in memory, seemingly forever or until shutdown.
The fix for this is to check is the promise is already resolved, and if so force our extra promise to resolve.
Fixes: open-telemetry/opentelemetry-php#1623