Skip to content

fix doctrine statement execution error #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

fix doctrine statement execution error #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Instrumentation/Doctrine/src/DoctrineInstrumentation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public static function register(): void

Context::storage()->attach($span->storeInContext($parent));
},
post: static function (\Doctrine\DBAL\Driver\Statement $statement, array $params, ResultInterface $result, ?Throwable $exception) {
post: static function (\Doctrine\DBAL\Driver\Statement $statement, array $params, ?ResultInterface $result, ?Throwable $exception) {
self::end($exception);
}
);
Expand Down
37 changes: 36 additions & 1 deletion src/Instrumentation/Doctrine/tests/Integration/DoctrineInstrumentationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function test_connection_exception(): void
]);
}

public function test_statement_execution(): void
public function test_connection_execute_statement(): void
{
$connection = self::createConnection();
$statement = self::fillDB();
Expand Down Expand Up @@ -202,4 +202,39 @@ public function test_transaction(): void
$sth = $connection->prepare('SELECT * FROM `technology`');
$this->assertSame(2, count($sth->executeQuery()->fetchAllAssociative()));
}

public function test_statement_execute(): void
{
$connection = self::createConnection();
$statement = self::fillDB();
$connection->executeStatement($statement);
$stmt = $connection->prepare('SELECT * FROM `technology`');
$this->storage->exchangeArray([]);
$stmt->executeQuery();
$this->assertCount(1, $this->storage);
$span = $this->storage->offsetGet(0);
$this->assertSame('Doctrine::execute', $span->getName());
$this->assertSame('execute', $span->getAttributes()->get(TraceAttributes::DB_OPERATION_NAME));
}

public function test_statement_execute_error(): void
{
$connection = self::createConnection();
$statement = self::fillDB();
$connection->executeStatement($statement);
$stmt = $connection->prepare('insert into technology(name, date) values (?, ?);');
$this->storage->exchangeArray([]);
$e = null;

try {
$stmt->executeQuery();
} catch (\Throwable $e) {
// do nothing
}
$this->assertNotNull($e);
$this->assertCount(1, $this->storage);
$span = $this->storage->offsetGet(0);
$this->assertSame('Error', $span->getStatus()->getCode());
$this->assertStringContainsString('Unable to execute', $span->getStatus()->getDescription());
}
}
Loading