Update monorepo meta files #402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
============================================
- Coverage 82.50% 81.45% -1.06%
+ Complexity 2009 1666 -343
============================================
Files 144 120 -24
Lines 8329 6950 -1379
============================================
- Hits 6872 5661 -1211
+ Misses 1457 1289 -168 Flags with carried forward coverage won't be shown. Click here to find out more. see 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This reverts commit 1c3eef5.
|
Reverted the last commit; |
|
Re: #403 (comment) from @ChrisLightfootWild:
Should we be removing some of these meta files then instead of maintaining them? The root |
I'm not sure either - I'd guess so to the exports in The dev-tools on the root composer - I've never used them but would presume it was there for something. I am sure @brettmc or @bobstrecansky know more on the requirements/history here 🤔 |
|
Brett has mentioned they’re used in the Packagist deployment, at least. |
It's used here for one function that I can see,
I don't think that it is used nowadays. I think we could get rid of it. 🤞 |
I’ll try removing it, running |
|
Sorry I haven’t got to the last point… I moved a week ago and everything is still getting unpacked. |
3 participants
Followup to this comment: #384 (comment)
If any of these changes are undesirable let me know and I'll update the PR.
Also, I noticed the src/Aws/ and src/ResourceDetectors/Azure/ libraries have inconsistent namespaces with the rest of the project; should those be updated? They would be breaking changes, but it looks like neither has hit a stable semantic version yet.