-
Notifications
You must be signed in to change notification settings - Fork 117
[sampler-xray]Added AWS X-Ray Sampler implementation #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add .gitsplit config so it can be published |
brettmc
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, there isn't any implementation of the AWS X-Ray Remote Sampler that allows customers to fetch their sampling rules and sample accordingly. This PR adds the implementation for that sampler. The customer is able to configure their sampling rules through AWS CloudWatch: https://docs.aws.amazon.com/xray/latest/devguide/xray-console-sampling.html. This implementation fetches the sampling rules using a set polling interval which is set when creating a new instance of AWSXRayRemoteSampler. This implementation is based on similar sampler implementations in other OTEL languages.
The sampling rule has two components: a reservoir and a fixed sampling rate. The idea here is once the sampling rule is matched and the reservoir is exhausted, the spans are sampled at a fixed rate according to their trace ids. As a result, the remote sampler samples the spans using two samplers: A reservoir sampler and a fixed rate sampler and chooses which one according to the reservoir quota.
Testing:
Unit Testing:
Wrote unit tests for the major classes to assert for correctness and they're all passing.
Manual Testing:
Wrote a sample app with manual instrumentation and hooked up the X-Ray Sampler to the Tracer. I then verified that requests are being sampled as expected using different sampling rules.