Yii: Fix span name to include {http.method} {http.route} #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
============================================
- Coverage 83.90% 83.79% -0.11%
- Complexity 1662 1689 +27
============================================
Files 99 102 +3
Lines 6642 6764 +122
============================================
+ Hits 5573 5668 +95
- Misses 1069 1096 +27 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
HeenaBansal20
force-pushed
the
fix/yii-span-name-as-per-otel-spec
branch
from
ab813fa to
ae05ee4
Compare
HeenaBansal20
force-pushed
the
fix/yii-span-name-as-per-otel-spec
branch
from
6218f08 to
099d2e2
Compare
HeenaBansal20
force-pushed
the
fix/yii-span-name-as-per-otel-spec
branch
2 times, most recently
from
44c3e91 to
fd32a26
Compare
HeenaBansal20
force-pushed
the
fix/yii-span-name-as-per-otel-spec
branch
from
5862801 to
2258b2c
Compare
|
@brettmc , This is expansion fix for the issue open-telemetry/opentelemetry-php#1671. |
brettmc
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded open-telemetry/opentelemetry-php#1671
Fixes YII psalm errors CI checks too in last commit.
