-
Notifications
You must be signed in to change notification settings - Fork 117
CodeIgniter: Fix span name to include {http.method} {http.route} #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeIgniter: Fix span name to include {http.method} {http.route} #422
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
============================================
- Coverage 83.90% 83.65% -0.26%
- Complexity 1662 1694 +32
============================================
Files 99 102 +3
Lines 6642 6779 +137
============================================
+ Hits 5573 5671 +98
- Misses 1069 1108 +39 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
b6ef6fc to
e5326d8
Compare
|
@brettmc , one more in queue to fix Span Name as per OTel Spec. |
src/Instrumentation/CodeIgniter/src/CodeIgniterInstrumentation.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Chris Lightfoot-Wild <[email protected]>
|
@brettmc @ChrisLightfootWild Thanks for reviewing the PR. Is it good to merge to master ? |
Hey @HeenaBansal20 👋 There's a spread of timezones in play here, so it will be merged once one of the maintainers is able to do so 👍 |
Expanded open-telemetry/opentelemetry-php#1671