Skip to content

Conversation

@HeenaBansal20
Copy link
Contributor

@HeenaBansal20 HeenaBansal20 commented Aug 6, 2025

@HeenaBansal20 HeenaBansal20 requested a review from a team as a code owner August 6, 2025 02:46
@HeenaBansal20 HeenaBansal20 changed the title Fix/code igniter span name as per otel spec CodeIgniter: Fix span name to include {http.method} {http.route} Aug 6, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.65%. Comparing base (9d513a6) to head (92672dd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #422      +/-   ##
============================================
- Coverage     83.90%   83.65%   -0.26%     
- Complexity     1662     1694      +32     
============================================
  Files            99      102       +3     
  Lines          6642     6779     +137     
============================================
+ Hits           5573     5671      +98     
- Misses         1069     1108      +39     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.98% <100.00%> (+0.43%) ⬆️
Instrumentation/Curl 87.66% <ø> (-2.77%) ⬇️
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/PostgreSql 93.54% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (ø)
Instrumentation/Yii 77.86% <ø> (?)
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 78.89% <100.00%> (+0.39%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4ed14...92672dd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HeenaBansal20 HeenaBansal20 force-pushed the fix/codeIgniter-span-name-as-per-otel-spec branch from b6ef6fc to e5326d8 Compare August 6, 2025 02:49
@HeenaBansal20
Copy link
Contributor Author

@brettmc , one more in queue to fix Span Name as per OTel Spec.

@HeenaBansal20
Copy link
Contributor Author

@brettmc @ChrisLightfootWild Thanks for reviewing the PR. Is it good to merge to master ?
If yes , please merge
Thanks .

@ChrisLightfootWild
Copy link
Contributor

@brettmc @ChrisLightfootWild Thanks for reviewing the PR. Is it good to merge to master ? If yes , please merge Thanks .

Hey @HeenaBansal20 👋

There's a spread of timezones in play here, so it will be merged once one of the maintainers is able to do so 👍

@brettmc brettmc merged commit be6ffdf into open-telemetry:main Aug 6, 2025
147 of 156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants