Skip to content

Conversation

@HeenaBansal20
Copy link
Contributor

This PR adds auto instrumentation for pHP output buffering control functions

ob_start()
ob_flush()
ob_clean()
flush()

@HeenaBansal20 HeenaBansal20 requested a review from a team as a code owner September 14, 2025 12:32
@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.90%. Comparing base (21c82d2) to head (d3523db).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/Instrumentation/IO/src/IOInstrumentation.php 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #437      +/-   ##
============================================
- Coverage     83.12%   81.90%   -1.22%     
- Complexity     1396     1988     +592     
============================================
  Files            97      137      +40     
  Lines          5599     8096    +2497     
============================================
+ Hits           4654     6631    +1977     
- Misses          945     1465     +520     
Flag Coverage Δ
Aws 93.41% <ø> (+0.82%) ⬆️
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.98% <ø> (ø)
Instrumentation/Curl 87.66% <ø> (ø)
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 0.00% <0.00%> (-70.69%) ⬇️
Instrumentation/Laravel 70.97% <ø> (?)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/PostgreSql 93.54% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Session 94.52% <ø> (?)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (ø)
Instrumentation/Yii 77.86% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/CloudTrace 89.77% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Sampler/Xray 78.23% <ø> (?)
Shims/OpenTracing 92.45% <ø> (ø)
Utils/Test 87.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Instrumentation/IO/src/IOInstrumentation.php 0.00% <0.00%> (-70.69%) ⬇️

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da45e60...d3523db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HeenaBansal20
Copy link
Contributor Author

@brettmc , Thanks for approving the PR. I have question..
Should I remove curl_exec and curl_init from IO package ? since they are already covered in seperate auto-curl package and these functions doesn't belong to IO category ?

@brettmc
Copy link
Contributor

brettmc commented Sep 15, 2025

Should I remove curl_exec and curl_init from IO package

Yes, I agree with you. Can you submit it as a separate PR?

@brettmc brettmc merged commit c876789 into open-telemetry:main Sep 15, 2025
157 of 167 checks passed
@HeenaBansal20
Copy link
Contributor Author

Should I remove curl_exec and curl_init from IO package

Yes, I agree with you. Can you submit it as a separate PR?

Sure I'll take it in a separate PR.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants