update resource detectors to align with spec changes#1573
Merged
brettmc merged 3 commits intoopen-telemetry:mainfrom May 1, 2025
Merged
update resource detectors to align with spec changes#1573brettmc merged 3 commits intoopen-telemetry:mainfrom
brettmc merged 3 commits intoopen-telemetry:mainfrom
Conversation
PR open-telemetry/opentelemetry-specification#4461 clarifies that some attributes (service.name, telemetry.*) are mandatory. It also reserves a couple of well-known detectors names (container, host, process, service) and the attributes they should populate. Consolidate some of our resource detectors into the built-in ones: - process-runtime into process, and deprecate - os into host, and deprecate - sdk-provided into sdk, and deprecate - service.name attribute from environment into service detector Add "mandatory attributes", which is currently service.name, and initially set this to "unknown_service:php" similar to Java's implementation. Ensure that the composite detector starts with mandatory attributes. Ensure that "sdk" and "service" detectors are always included from ResourceInfoFactory. The deprecated detectors are still available, but do not do anything.
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
============================================
- Coverage 70.87% 70.75% -0.12%
+ Complexity 2766 2755 -11
============================================
Files 408 407 -1
Lines 8356 8319 -37
============================================
- Hits 5922 5886 -36
+ Misses 2434 2433 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bobstrecansky
approved these changes
Apr 30, 2025
ChrisLightfootWild
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR open-telemetry/opentelemetry-specification#4461 clarifies that some attributes (service.name, telemetry.*) are mandatory. It also reserves a couple of well-known detectors names (container, host, process, service) and the attributes they should populate. Consolidate some of our resource detectors into the built-in ones:
Add "mandatory attributes", which is currently service.name, and initially set this to "unknown_service:php" similar to Java's implementation. Ensure that the composite detector starts with mandatory attributes.
Ensure that "sdk" and "service" detectors are always included from ResourceInfoFactory.
The deprecated detectors are still available, but do not do anything.