-
Notifications
You must be signed in to change notification settings - Fork 212
feat: Add experimental response propagator interface #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
9461d50
a9a230b
eb307db
fc6fd2f
b49565a
968f66c
f903e5e
1c343c4
422c597
e9e72fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,8 +11,11 @@ | |
| use OpenTelemetry\API\Configuration\Context; | ||
| use OpenTelemetry\Config\SDK\Configuration\Validation; | ||
| use OpenTelemetry\Config\SDK\Parser\AttributesParser; | ||
| use OpenTelemetry\Context\Propagation\MultiResponsePropagator; | ||
| use OpenTelemetry\Context\Propagation\MultiTextMapPropagator; | ||
| use OpenTelemetry\Context\Propagation\NoopResponsePropagator; | ||
| use OpenTelemetry\Context\Propagation\NoopTextMapPropagator; | ||
| use OpenTelemetry\Context\Propagation\ResponsePropagatorInterface; | ||
| use OpenTelemetry\Context\Propagation\TextMapPropagatorInterface; | ||
| use OpenTelemetry\SDK\Common\Attribute\Attributes; | ||
| use OpenTelemetry\SDK\Common\Instrumentation\InstrumentationScopeFactory; | ||
|
|
@@ -87,6 +90,9 @@ final class OpenTelemetrySdk implements ComponentProvider | |
| * propagator: array{ | ||
| * composite: list<ComponentPlugin<TextMapPropagatorInterface>>, | ||
| * }, | ||
| * response_propagator: array{ | ||
| * composite: list<ComponentPlugin<ResponsePropagatorInterface>>, | ||
| * }, | ||
| * tracer_provider: array{ | ||
| * limits: array{ | ||
| * attribute_value_length_limit: ?int<0, max>, | ||
|
|
@@ -177,6 +183,13 @@ public function createPlugin(array $properties, Context $context): SdkBuilder | |
| $propagator = ($propagators === []) ? NoopTextMapPropagator::getInstance() : new MultiTextMapPropagator($propagators); | ||
| $sdkBuilder->setPropagator($propagator); | ||
|
|
||
| $responsePropagators = []; | ||
| foreach ($properties['response_propagator']['composite'] as $plugin) { | ||
|
||
| $responsePropagators[] = $plugin->create($context); | ||
| } | ||
| $responsePropagator = ($responsePropagators === []) ? NoopResponsePropagator::getInstance() : new MultiResponsePropagator($responsePropagators); | ||
| $sdkBuilder->setResponsePropagator($responsePropagator); | ||
|
|
||
| if ($properties['disabled']) { | ||
| return $sdkBuilder; | ||
| } | ||
|
|
@@ -403,6 +416,7 @@ public function getConfig(ComponentProviderRegistry $registry, NodeBuilder $buil | |
| ->append($this->getTracerProviderConfig($registry, $builder)) | ||
| ->append($this->getMeterProviderConfig($registry, $builder)) | ||
| ->append($this->getLoggerProviderConfig($registry, $builder)) | ||
| ->append($this->getResponsePropagatorConfig($registry, $builder)) | ||
| ->end(); | ||
|
|
||
| return $node; | ||
|
|
@@ -684,4 +698,42 @@ private function getPropagatorConfig(ComponentProviderRegistry $registry, NodeBu | |
|
|
||
| return $node; | ||
| } | ||
|
|
||
| private function getResponsePropagatorConfig(ComponentProviderRegistry $registry, NodeBuilder $builder): ArrayNodeDefinition | ||
| { | ||
| $node = $builder->arrayNode('response_propagator'); | ||
| $node | ||
| ->beforeNormalization() | ||
| ->ifArray() | ||
| ->then(static function (array $value): array { | ||
| $existing = []; | ||
| foreach ($value['composite'] ?? [] as $item) { | ||
| $existing[] = key($item); | ||
| } | ||
| foreach (explode(',', $value['composite_list'] ?? '') as $name) { | ||
| $name = trim($name); | ||
| if ($name !== '' && !in_array($name, $existing)) { | ||
| $value['composite'][][$name] = null; | ||
| $existing[] = $name; | ||
| } | ||
| } | ||
|
|
||
| unset($value['composite_list']); | ||
|
|
||
| return $value; | ||
| }) | ||
| ->end(); | ||
|
|
||
| $node | ||
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->append($registry->componentList('composite', ResponsePropagatorInterface::class)) | ||
| // ->arrayNode('composite_list') | ||
brettmc marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // ->scalarPrototype()->end() | ||
| // ->end() | ||
| ->end() | ||
| ; | ||
|
|
||
| return $node; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace OpenTelemetry\Config\SDK\ComponentProvider\Propagator; | ||
|
|
||
| use OpenTelemetry\API\Configuration\Config\ComponentPlugin; | ||
| use OpenTelemetry\API\Configuration\Config\ComponentProvider; | ||
| use OpenTelemetry\API\Configuration\Config\ComponentProviderRegistry; | ||
| use OpenTelemetry\API\Configuration\Context; | ||
| use OpenTelemetry\Context\Propagation\MultiResponsePropagator; | ||
| use OpenTelemetry\Context\Propagation\ResponsePropagatorInterface; | ||
| use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition; | ||
| use Symfony\Component\Config\Definition\Builder\NodeBuilder; | ||
|
|
||
| /** | ||
| * @implements ComponentProvider<ResponsePropagatorInterface> | ||
| */ | ||
| final class ResponsePropagatorComposite implements ComponentProvider | ||
| { | ||
| /** | ||
| * @param list<ComponentPlugin<ResponsePropagatorInterface>> $properties | ||
| */ | ||
| #[\Override] | ||
| public function createPlugin(array $properties, Context $context): ResponsePropagatorInterface | ||
| { | ||
| $responsePropagators = []; | ||
| foreach ($properties as $plugin) { | ||
| $responsePropagators[] = $plugin->create($context); | ||
| } | ||
|
|
||
| return new MultiResponsePropagator($responsePropagators); | ||
| } | ||
|
|
||
| #[\Override] | ||
| public function getConfig(ComponentProviderRegistry $registry, NodeBuilder $builder): ArrayNodeDefinition | ||
| { | ||
| return $registry->componentNames('composite', ResponsePropagatorInterface::class); | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.