-
Notifications
You must be signed in to change notification settings - Fork 212
feat: Add experimental response propagator interface #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brettmc
merged 10 commits into
open-telemetry:main
from
jerrytfleung:responsePropagator-registry
Sep 19, 2025
+835
−16
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9461d50
Added experimental response propagator
jerrytfleung a9a230b
Added response propagator interface to Globals
jerrytfleung eb307db
changed to experimental_response_propagator
jerrytfleung fc6fd2f
Update src/API/Globals.php
jerrytfleung b49565a
Update src/Context/Propagation/ResponsePropagatorInterface.php
jerrytfleung 968f66c
Update src/Config/SDK/ComponentProvider/OpenTelemetrySdk.php
jerrytfleung f903e5e
Changed experimental_response_propagator to response_propagator/devel…
jerrytfleung 1c343c4
Cleaned up the comment
jerrytfleung 422c597
Bumped context and api version
jerrytfleung e9e72fb
Bumped open-telemetry/sdk in open-telemetry/sdk-configuration
jerrytfleung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/Config/SDK/ComponentProvider/Propagator/ResponsePropagatorComposite.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace OpenTelemetry\Config\SDK\ComponentProvider\Propagator; | ||
|
|
||
| use OpenTelemetry\API\Configuration\Config\ComponentPlugin; | ||
| use OpenTelemetry\API\Configuration\Config\ComponentProvider; | ||
| use OpenTelemetry\API\Configuration\Config\ComponentProviderRegistry; | ||
| use OpenTelemetry\API\Configuration\Context; | ||
| use OpenTelemetry\Context\Propagation\MultiResponsePropagator; | ||
| use OpenTelemetry\Context\Propagation\ResponsePropagatorInterface; | ||
| use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition; | ||
| use Symfony\Component\Config\Definition\Builder\NodeBuilder; | ||
|
|
||
| /** | ||
| * @implements ComponentProvider<ResponsePropagatorInterface> | ||
| */ | ||
| final class ResponsePropagatorComposite implements ComponentProvider | ||
| { | ||
| /** | ||
| * @param list<ComponentPlugin<ResponsePropagatorInterface>> $properties | ||
| */ | ||
| #[\Override] | ||
| public function createPlugin(array $properties, Context $context): ResponsePropagatorInterface | ||
| { | ||
| $responsePropagators = []; | ||
| foreach ($properties as $plugin) { | ||
| $responsePropagators[] = $plugin->create($context); | ||
| } | ||
|
|
||
| return new MultiResponsePropagator($responsePropagators); | ||
| } | ||
|
|
||
| #[\Override] | ||
| public function getConfig(ComponentProviderRegistry $registry, NodeBuilder $builder): ArrayNodeDefinition | ||
| { | ||
| return $registry->componentNames('composite', ResponsePropagatorInterface::class); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.