Skip to content

Update __init__.py #1205 #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+97 −168
Draft

Update __init__.py #1205 #1238

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81fd1ff
Update __init__.py
rahuldimri Aug 22, 2022
1874501
Update __init__.py
rahuldimri Aug 25, 2022
ac0e4e0
Update __init__.py
rahuldimri Feb 1, 2023
ad84afa
Update __init__.py
rahuldimri Dec 4, 2024
5e207a9
Update __init__.py
rahuldimri Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...instrumentation-elasticsearch/src/opentelemetry/instrumentation/elasticsearch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def _instrument(self, **kwargs):
response_hook = kwargs.get("response_hook")
_wrap(
elasticsearch,
"Transport.perform_request",
"AsyncTransport.perform_request",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes working on the rest of the code. thanks for keeping an eye on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert this to draft if it's not ready for reviews yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add support for AsyncTransport ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the feature request. Did you read the issue? You don't replace one with other. And there should be tests.

_wrap_perform_request(
tracer, self._span_name_prefix, request_hook, response_hook
),
Expand Down