Skip to content

issue 1918: Ensure string values for span status and attribute values #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

issue 1918: Ensure string values for span status and attribute values #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27433cf
issue 1918: Ensure string values for span status and attribute values
cmpilato Oct 20, 2023
a8fb179
issue 1918: Add a ChangeLog entry
cmpilato Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#2874](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2874))
- `opentelemetry-instrumentation-confluent-kafka` Fix to allow `topic` to be extracted from `kwargs` in `produce()`
([#2901])(https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2901)
- `opentelemetry-instrumentation-pymongo` Fix type-related errors in certain usages of the PyMongo span `DB_MONGODB_COLLECTION` attribute and trace error status descriptions
([#2010](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2010))

### Breaking changes

Expand Down
4 changes: 2 additions & 2 deletions ...entelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def started(self, event: monitoring.CommandStartedEvent):
)
span.set_attribute(SpanAttributes.DB_NAME, event.database_name)
span.set_attribute(SpanAttributes.DB_STATEMENT, statement)
if collection:
if collection and isinstance(collection, str):
span.set_attribute(
SpanAttributes.DB_MONGODB_COLLECTION, collection
)
Expand Down Expand Up @@ -185,7 +185,7 @@ def failed(self, event: monitoring.CommandFailedEvent):
if span is None:
return
if span.is_recording():
span.set_status(Status(StatusCode.ERROR, event.failure))
span.set_status(Status(StatusCode.ERROR, str(event.failure)))
try:
self.failed_hook(span, event)
except (
Expand Down