Adds NoOpTracerProvider test case for botocore instrumentation #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwejanraj
changed the title
brianwarner
force-pushed
the
988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation
branch
from
be1e3ca to
b2b1d22
Compare
|
@emdneto |
shwejanraj
force-pushed
the
988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation
branch
2 times, most recently
from
4e4ffa0 to
8612ef7
Compare
shwejanraj
force-pushed
the
988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation
branch
from
8612ef7 to
82a64da
Compare
emdneto
reviewed
Jun 24, 2024
Signed-off-by: Shwejan Bhupathi <[email protected]>
Signed-off-by: Shwejan Bhupathi <[email protected]>
Signed-off-by: Shwejan Bhupathi <[email protected]>
brianwarner
force-pushed
the
988-Adds-NoOpTracerProvider-test-cases-for-botocore-instrumentation
branch
from
82a64da to
bae1df1
Compare
lzchen
approved these changes
Jul 9, 2024
|
Are you still working on this? |
@lzchen . I am working on this and @shwejanraj was working with me on this issue . I will rebase and update the PR . Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds NoOpTracerProvider test cases for botocore instrumentation.
Fixes #988
How Has This Been Tested?
tox -e test-instrumentation-botocore
Does This PR Require a Core Repo Change?
No.