Skip to content

Fix missing attributes in RedisCluster spans #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix missing attributes in RedisCluster spans #2626

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
65e2c64
fix missing attributes in RedisCluster spans
a-cid Jun 20, 2024
8ff71aa
Merge branch 'main' into patch-1
a-cid Jun 21, 2024
7802ade
added redis cluster test
a-cid Jun 21, 2024
f3024bc
Merge branch 'main' into patch-1
a-cid Jun 21, 2024
0c97cdf
fix: avoid workaround for async RedisCluster
a-cid Jun 26, 2024
a0f908a
linting and formatting
a-cid Jun 26, 2024
848cc51
add CHANGELOG entry
a-cid Jun 26, 2024
5e71011
Update CHANGELOG.md
xrmx Jun 26, 2024
045c9c6
Merge branch 'main' into patch-1
xrmx Jul 10, 2024
ac8cc13
Merge branch 'main' into patch-1
a-cid Sep 20, 2024
f5c4bf4
rename conn to instance
a-cid Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...n/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def response_hook(span, instance, response):


def _set_connection_attributes(span, conn):
if hasattr(conn, "nodes_manager"):
conn = conn.nodes_manager.default_node.redis_connection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not access connection_kwargs directly from the NodeManager or is this a different set of kwargs?

Copy link
Author

@a-cid a-cid Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I've been a bit busy with work.

The call to cleanup_kwargs removes host and port from the kwargs passed to the NodeManager, so we have to get them from the nodes.

if not span.is_recording() or not hasattr(conn, "connection_pool"):
return
for key, value in _extract_conn_attributes(
Expand Down