-
Notifications
You must be signed in to change notification settings - Fork 798
Implement new HTTP semantic convention opt-in for Falcon #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lzchen
merged 36 commits into
open-telemetry:main
from
FilipNikolovski:falcon_new_semconv
Jan 13, 2025
Merged
Changes from 20 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
2d68dc5
Implement new HTTP semantic convention opt-in for Falcon
228897d
fix tests for falcon 1 & 2
2d70a72
resolve conflicts
a9a30a8
add semconv status as migration for falcon in instrumentations readme
b3db908
set schema_url based on the opt-in mode
aa54865
add histograms based on opt-in mode; set metrics attributes; update t…
2ed1461
run ruff
e8d3e6c
disable too-many-public-methods lint rule for TestFalconInstrumentation
d1e81c0
Merge branch 'main' into falcon_new_semconv
1815495
add _semconv_status in package.py
0307008
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
a4419a6
Merge branch 'main' into falcon_new_semconv
emdneto 7754f0d
cleanup imports
b941569
set request attributes in env, set status code in metric attributes i…
e14eaf9
Merge branch 'main' into falcon_new_semconv
c44244c
fix exceptions to not be masked as 500 on every thrown exception
1cecee6
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
59586fd
resolve lint issues
6ac9e98
run tox -e generate; fix typo
d0757ec
Merge branch 'main' into falcon_new_semconv
emdneto 2d6b160
sort imports
ecd351f
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
3d5ec55
fix tests
e51f79d
Merge branch 'open-telemetry:main' into falcon_new_semconv
FilipNikolovski bfb8a53
Merge branch 'main' of https://github.com/FilipNikolovski/opentelemet…
606958a
update changelog
6ee7d35
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
e12ace6
Merge branch 'main' into falcon_new_semconv
8b281b2
update tests
c662eae
disable lint check on too-many-nested-blocks in metrics test
7702a59
use add_response_attributes function from wsgi
174e144
resolve conflicts
241a849
cleanup unused functions
89a2a00
Merge branch 'main' into falcon_new_semconv
2a5fac7
cleanup
374f26d
Merge branch 'main' into falcon_new_semconv
lzchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ | |
_instruments = ("falcon >= 1.4.1, < 4.0.0",) | ||
|
||
_supports_metrics = True | ||
|
||
_semconv_status = "migration" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.