Update README.rst #2849
Merged
Update README.rst #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL link is incorrect; it should be a repository in the open-telemetry account.
zhihali
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
I agree this should be updated. I've compared the two versions, and the opentelemetry one is more up to date. Here are some key differences for the approvers:
Instrumentation Versions: opentelemetry uses 0.49b0.dev, while the personal repo uses 0.44b0.dev.
Library Versions:
confluent-kafka: opentelemetry supports up to 2.4.0, personal repo up to 2.2.0.
elasticsearch: opentelemetry starts at 6.0, personal repo from 2.0.
Additional Libraries: opentelemetry includes kafka-python-ng, which isn't in the personal repo.
xrmx
approved these changes
Sep 4, 2024
|
Good catch! |
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
The URL link is incorrect; it should be a repository in the open-telemetry account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL link is incorrect; it should be a repository in the open-telemetry account.
Description
The URL link
https://github.com/flands/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.pyshould behttps://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
It’s only a documentation update, so there is no need to test.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.