Skip to content

Fix instrument types in system metrics #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix instrument types in system metrics #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#2860](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2860))
- `opentelemetry-instrumentation-aiokafka` Add instrumentor and auto instrumentation support for aiokafka
([#2082](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2082))
- `opentelemetry-instrumentation-system-metrics` Fix instrument types in system metrics
([#2865](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2865))

## Version 1.27.0/0.48b0 ()

Expand Down
12 changes: 5 additions & 7 deletions ...strumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,10 @@ def _instrument(self, **kwargs):
)

if "system.network.connections" in self._config:
self._meter.create_observable_up_down_counter(
self._meter.create_observable_gauge(
name="system.network.connections",
callbacks=[self._get_system_network_connections],
description="System network connections",
unit="connections",
)

if "system.thread_count" in self._config:
Expand All @@ -346,7 +345,7 @@ def _instrument(self, **kwargs):
)

if "process.runtime.memory" in self._config:
self._meter.create_observable_up_down_counter(
self._meter.create_observable_gauge(
name=f"process.runtime.{self._python_implementation}.memory",
callbacks=[self._get_runtime_memory],
description=f"Runtime {self._python_implementation} memory",
Expand All @@ -367,15 +366,14 @@ def _instrument(self, **kwargs):
"The process.runtime.gc_count metric won't be collected because the interpreter is PyPy"
)
else:
self._meter.create_observable_counter(
self._meter.create_observable_gauge(
name=f"process.runtime.{self._python_implementation}.gc_count",
callbacks=[self._get_runtime_gc_count],
description=f"Runtime {self._python_implementation} GC count",
unit="bytes",
)

if "process.runtime.thread_count" in self._config:
self._meter.create_observable_up_down_counter(
self._meter.create_observable_gauge(
name=f"process.runtime.{self._python_implementation}.thread_count",
callbacks=[self._get_runtime_thread_count],
description="Runtime active threads count",
Expand All @@ -398,7 +396,7 @@ def _instrument(self, **kwargs):
)

if "process.open_file_descriptor.count" in self._config:
self._meter.create_observable_up_down_counter(
self._meter.create_observable_gauge(
name="process.open_file_descriptor.count",
callbacks=[self._get_open_file_descriptors],
description="Number of file descriptors in use by the process.",
Expand Down