feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimastbk
changed the title
xrmx
reviewed
Sep 17, 2024
instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Sep 17, 2024
...pentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/__init__.py
Show resolved
Hide resolved
|
Would you mind adding yourself to component_owners.yml according to CONTRIBUTING.MD |
|
@lzchen done |
emdneto
reviewed
Sep 19, 2024
xrmx
approved these changes
Sep 25, 2024
emdneto
approved these changes
Sep 25, 2024
xrmx
added a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
…anext, add tests (open-telemetry#2874) * add tests * add to CHANGELOG * add tests for baggage * wrap getone instead of __anext__ * split sync and async tests (fix review) * add dimastbk to component_owners.yml for aiokafka * Update CHANGELOG.md --------- Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap getone instead of anext
Add tests for opentelemetry-instrumentation-aiokafka (#2082)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.