Skip to content

Add generate-workflows usage to CONTRIBUTING #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2024
Merged

Add generate-workflows usage to CONTRIBUTING #2977

merged 4 commits into from
Nov 11, 2024
+3 −1

Conversation

@tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 7, 2024 •
edited by emdneto
Loading

Description

Adds missing info on generate_workflows.py usage.

Partially address open-telemetry/opentelemetry-python#4263

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

n/a

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

xrmx
xrmx reviewed Nov 8, 2024
View reviewed changes
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review November 8, 2024 18:34
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 8, 2024 18:34
@tammy-baylis-swi tammy-baylis-swi requested a review from xrmx November 8, 2024 18:34
@tammy-baylis-swi
Copy link
Contributor Author

Do we want an Issue and Changelog update for this?

emdneto
emdneto approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please do the same for core? Maybe you can reference this issue: open-telemetry/opentelemetry-python#4263

@tammy-baylis-swi
Copy link
Contributor Author

Thanks! Could you please do the same for core? Maybe you can reference this issue: open-telemetry/opentelemetry-python#4263

Sounds good! Core PR here: open-telemetry/opentelemetry-python#4266

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 11, 2024
@lzchen lzchen merged commit 66a6780 into open-telemetry:main Nov 11, 2024
566 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the add-generate-workflows-info branch November 12, 2024 18:41
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
@tammy-baylis-swi @xrmx
Add generate-workflows usage to CONTRIBUTING (open-telemetry#2977)
e00695a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@emdneto emdneto emdneto approved these changes

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tammy-baylis-swi @xrmx @emdneto @lzchen