Skip to content

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Nov 13, 2024

Description

Same as open-telemetry/opentelemetry-python#4238
Prepare tox for tox-uv

@emdneto emdneto requested a review from a team as a code owner November 13, 2024 23:04
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto marked this pull request as draft November 14, 2024 00:21
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto marked this pull request as ready for review November 14, 2024 01:11
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 14, 2024
Copy link
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't update [testenv:docs] because it's failing: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/11827704954/job/32956450432

One solution would be separate docs-requirements.txt in two requirements-files (docs-requirements.txt and readthedocs.txt and use the appropriate one for .readthedocs.yml.

Updated docs-requirements.txt to not use editable installs pypa/pip#12502

Signed-off-by: emdneto <[email protected]>
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a tox expert but it simplifies tox.ini and removes 200 lines so LGTM

@xrmx xrmx merged commit 59ecd4d into open-telemetry:main Dec 17, 2024
573 checks passed
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
* move pip install from command to deps

Signed-off-by: emdneto <[email protected]>

* add docker-test-requirements.txt

Signed-off-by: emdneto <[email protected]>

* fix celery and docs

Signed-off-by: emdneto <[email protected]>

* fix

Signed-off-by: emdneto <[email protected]>

* fix tox.ini

Signed-off-by: emdneto <[email protected]>

* update docs

Signed-off-by: emdneto <[email protected]>

* Update tox.ini

---------

Signed-off-by: emdneto <[email protected]>
Co-authored-by: Leighton Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build & infra Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants