Skip to content

Conversation

@opentelemetrybot
Copy link
Contributor

Prepare release 1.28.2/0.49b2.

@aabmass aabmass added the Skip generate-workflows To be used for release PRs label Nov 15, 2024
@aabmass
Copy link
Member

aabmass commented Nov 15, 2024

This took longer than expected. Going to update the changelog date and finish release on Monday 🏖️

# limitations under the License.

__version__ = "2.0.0.dev"
__version__ = "0.49b2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong

# limitations under the License.

__version__ = "2.1.0.dev"
__version__ = "1.28.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong aswell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should skip packages that are released individually no?

Copy link
Contributor

@xrmx xrmx Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like the script updating this is also forgetting about exporter/, propagator/and processor/ and maybe other dirs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should skip packages that are released individually no?

I think @lzchen mentioned this, I will make a note of it. IIUC it should be inconsequential because the independent release packages won't be uploaded during the release workflow. WDYT?

looks like the script updating this is also forgetting about exporter/, propagator/and processor/ and maybe other dirs?

Ahh that's more concerning, I'll take a look thanks!

Copy link
Member

@aabmass aabmass Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the script updating this is also forgetting about exporter/, propagator/and processor/ and maybe other dirs?

Ahh that's more concerning, I'll take a look thanks!

I guess we're missing a ton of entries for these in eachdist.ini?

Copy link
Member

@aabmass aabmass Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it out, #3016

Running workflow in that PR generated the below diff stat vs this PR

Details

 _template/version.py                                                                                                  |   2 +-
 exporter/opentelemetry-exporter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/version.py |   2 +-
 exporter/opentelemetry-exporter-richconsole/src/opentelemetry/exporter/richconsole/version.py                         |   2 +-
 instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/version.py  |   2 +-
 instrumentation/opentelemetry-instrumentation-aiohttp-client/pyproject.toml                                           |   2 +-
 instrumentation/opentelemetry-instrumentation-aiohttp-server/pyproject.toml                                           |   2 +-
 instrumentation/opentelemetry-instrumentation-asgi/pyproject.toml                                                     |   2 +-
 instrumentation/opentelemetry-instrumentation-django/pyproject.toml                                                   |   2 +-
 instrumentation/opentelemetry-instrumentation-falcon/pyproject.toml                                                   |   2 +-
 instrumentation/opentelemetry-instrumentation-fastapi/pyproject.toml                                                  |   2 +-
 instrumentation/opentelemetry-instrumentation-flask/pyproject.toml                                                    |   2 +-
 instrumentation/opentelemetry-instrumentation-httpx/pyproject.toml                                                    |   2 +-
 instrumentation/opentelemetry-instrumentation-pyramid/pyproject.toml                                                  |   2 +-
 instrumentation/opentelemetry-instrumentation-requests/pyproject.toml                                                 |   2 +-
 instrumentation/opentelemetry-instrumentation-starlette/pyproject.toml                                                |   2 +-
 instrumentation/opentelemetry-instrumentation-tornado/pyproject.toml                                                  |   2 +-
 instrumentation/opentelemetry-instrumentation-urllib/pyproject.toml                                                   |   2 +-
 instrumentation/opentelemetry-instrumentation-urllib3/pyproject.toml                                                  |   2 +-
 instrumentation/opentelemetry-instrumentation-wsgi/pyproject.toml                                                     |   2 +-
 opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py                                      | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------
 processor/opentelemetry-processor-baggage/src/opentelemetry/processor/baggage/version.py                              |   2 +-
 propagator/opentelemetry-propagator-ot-trace/src/opentelemetry/propagators/ot_trace/version.py                        |   2 +-
 scripts/eachdist.py                                                                                                   |  13 +++++++++++++
 sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/version.py                          |   2 +-
 util/opentelemetry-util-http/src/opentelemetry/util/http/version.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at the Prepare release PR: #3017

@aabmass
Copy link
Member

aabmass commented Nov 18, 2024

Will run the release workflow again and generate a new PR

@aabmass aabmass closed this Nov 18, 2024
@aabmass aabmass deleted the opentelemetrybot/prepare-release-1.28.2-0.49b2 branch November 18, 2024 17:08
@aabmass
Copy link
Member

aabmass commented Nov 18, 2024

#3017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip generate-workflows To be used for release PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.