Skip to content

Fix eachdist.py patch release to respect "all" and "excluded" #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix eachdist.py patch release to respect "all" and "excluded" #3016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/eachdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,9 @@ def update_dependencies(targets, version, packages):

def update_patch_dependencies(targets, version, prev_version, packages):
print("updating patch dependencies")
if "all" in packages:
packages.extend(targets)
Comment on lines +670 to +671
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from above https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3016/files#diff-500edb13b69ad54b47997c7d8c869ad8adbe89ba904f5c80619636141c9f4fd5R651-R652


# PEP 508 allowed specifier operators
operators = ["==", "!=", "<=", ">=", "<", ">", "===", "~=", "="]
operators_pattern = "|".join(re.escape(op) for op in operators)
Expand Down Expand Up @@ -715,10 +718,12 @@ def release_args(args):
versions = args.versions
updated_versions = []

# remove excluded packages
excluded = cfg["exclude_release"]["packages"].split()
targets = [
target for target in targets if basename(target) not in excluded
]

for group in versions.split(","):
mcfg = cfg[group]
version = mcfg["version"]
Expand All @@ -742,10 +747,18 @@ def patch_release_args(args):
targets = list(find_targets_unordered(rootpath))
cfg = ConfigParser()
cfg.read(str(find_projectroot() / "eachdist.ini"))

# remove excluded packages
excluded = cfg["exclude_release"]["packages"].split()
targets = [
target for target in targets if basename(target) not in excluded
]

# stable
mcfg = cfg["stable"]
packages = mcfg["packages"].split()
print(f"update stable packages to {args.stable_version}")

update_patch_dependencies(
targets, args.stable_version, args.stable_version_prev, packages
)
Expand Down
Loading