Skip to content

Conversation

@Kludex
Copy link
Member

@Kludex Kludex commented Nov 26, 2024

I found this while adding type hints on #3045.

@Kludex Kludex requested a review from a team as a code owner November 26, 2024 07:11
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xrmx xrmx enabled auto-merge (squash) November 26, 2024 21:15
@xrmx xrmx merged commit 16ebf25 into open-telemetry:main Nov 26, 2024
566 checks passed
@Kludex Kludex deleted the replace-_meter_provider-by-meter_provider branch November 28, 2024 12:22
xrmx added a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
…ent` (open-telemetry#3048)

* starlette: Replace `_meter_provider` by `meter_provider` on `_instrument`

* Add PR on the changelog

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants