contributing: add guidance on how to update package versions support #3090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
7 tasks
There was a problem hiding this comment.
Looks good, I have some suggestions to clarify the location of where commands should run. Also here and everywhere else in this file, we should switch from backticking tox.ini to a link to it. This helps markdown link checker ensure there's not a typo there, also, readers can click it!
Signed-off-by: emdneto <[email protected]>
xrmx
approved these changes
Dec 11, 2024
Co-authored-by: Riccardo Magliocchetti <[email protected]>
Co-authored-by: Riccardo Magliocchetti <[email protected]>
emdneto
commented
Dec 12, 2024
tammy-baylis-swi
approved these changes
Dec 17, 2024
lzchen
approved these changes
Dec 17, 2024
emdneto
commented
Dec 17, 2024
xrmx
added a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
…pen-telemetry#3090) * contributing: add guidance for update package versions support Signed-off-by: emdneto <[email protected]> * update the guide Signed-off-by: emdneto <[email protected]> * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Riccardo Magliocchetti <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Riccardo Magliocchetti <[email protected]> * Update CONTRIBUTING.md to add docs instructions * Update CONTRIBUTING.md * Update CONTRIBUTING.md --------- Signed-off-by: emdneto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve contributing guide to make explicit how to support new versions of instrumentation packages