[chore] Removed $ from command for contribution guidance #3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Dec 18, 2024
gyliu513
force-pushed
the
contrib
branch
2 times, most recently
from
531e3fc to
81370fc
Compare
emdneto
approved these changes
Dec 19, 2024
emdneto
reviewed
Dec 19, 2024
xrmx
reviewed
Dec 19, 2024
The copy in markdown file always copy the $ as well when copying the command, I need to remove the $ manually each time.
lzchen
approved these changes
Dec 19, 2024
codefromthecrypt
approved these changes
Dec 20, 2024
xrmx
approved these changes
Dec 23, 2024
xrmx
added a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
…try#3114) The copy in markdown file always copy the $ as well when copying the command, I need to remove the $ manually each time. Co-authored-by: Leighton Chen <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy in markdown file always copy the $ as well when copying the command, I need to remove the $ manually each time.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.