Support PEP 561 to opentelemetry-instrumentation-urllib3
#3130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Dec 23, 2024
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Show resolved
Hide resolved
xrmx
reviewed
Dec 23, 2024
| from typing import Collection | ||
| from typing import Any, Callable, Collection, Mapping, Optional | ||
|
|
||
| import urllib3.connectionpool |
There was a problem hiding this comment.
Maybe update callers of this while we are it? It looks like we are only using urllib3.connectionpool.HTTPConnectionPool
There was a problem hiding this comment.
You mean the wrap calls? I didn't want to do it because it may have some runtime unexpected behavior that I'm not aware. Should I change it as well?
But FYI, it was on purpose.
emdneto
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.